Open
Conversation
4 tasks
jaewonLeeKOR
requested changes
Feb 11, 2026
Member
jaewonLeeKOR
left a comment
jaewonLeeKOR
left a comment
There was a problem hiding this comment.
페이지 라우팅은 오프라인에서 같이 얘기해보죠
Comment on lines
+76
to
+106
| const fetchAndMove = async () => { | ||
| try { | ||
| const detail = await getSightDetail({ | ||
| id: sightId, | ||
| longitude: location.longitude, | ||
| latitude: location.latitude, | ||
| }); | ||
|
|
||
| // 지도 이동 | ||
| mapRef.current?.moveToLocation({ | ||
| latitude: detail.latitude, | ||
| longitude: detail.longitude, | ||
| latitudeDelta: 0.01, | ||
| longitudeDelta: 0.01, | ||
| }); | ||
|
|
||
| // 선택된 관광지 설정 | ||
| const sight: SightInfo = { | ||
| id: sightId, | ||
| title: detail.title, | ||
| longitude: detail.longitude, | ||
| latitude: detail.latitude, | ||
| geoHash: "", | ||
| }; | ||
|
|
||
| useSightStore.getState().selectSight(sight); | ||
| useSightStore.getState().setSightDetail(detail); | ||
| } catch (error) { | ||
| console.error("관광지 조회 실패:", error); | ||
| } | ||
| }; |
Member
There was a problem hiding this comment.
fetchAndMove 메서드를 훅으로 빼내서 활용해도 좋을거 같습니다
|
|
||
| const [searchText, setSearchText] = useState(""); | ||
| const [showResults, setShowResults] = useState(false); | ||
| const { sightId } = useLocalSearchParams<{ sightId?: string }>(); |
Member
There was a problem hiding this comment.
파라미터명을 더 정확히 사용하는것도 좋을거 같아요.
코드를 읽을때도 한번에 이해가 어렵기도 하고 sightId는 여러 인터페이스 안에서 사용되고 있는 변수명이기도 해서요.
|
|
||
| fetchAndMove(); | ||
| } | ||
| }, [sightId, location.latitude, location.longitude]); |
Member
There was a problem hiding this comment.
기존에 관광지 세부정보를 보여주는 방식과는 다른 방식을 사용했는데 어떻게 사용하든 통합을 하는게 좋을거 같습니다.
Comment on lines
+36
to
+38
| pathname: "/(tabs)/story", | ||
| params: { storySpotId: item.itemId }, | ||
| } as any); |
Member
There was a problem hiding this comment.
이야기쪽은 세부정보 페이지로 이동하는 부분을 구현하지 않는거죠?
Comment on lines
+52
to
+63
| const renderItem = ({ item }: { item: CompletedRouteItem }) => ( | ||
| <CardWrapper> | ||
| <SightCard | ||
| image={item.itemImageUrl} | ||
| sightName={item.itemName} | ||
| sightTheme={item.itemType === "SIGHT" ? "관광지" : "이야기 스팟"} | ||
| iconStyle="DETAIL" | ||
| iconColor={theme.colors.text.textSecondary} | ||
| onCardPress={() => handleCardPress(item)} | ||
| /> | ||
| </CardWrapper> | ||
| ); |
Member
There was a problem hiding this comment.
피그마에서는 이야기 스팟의 카드와 관광지 카드의 디자인이 다른데 의도적으로 통일시킨건가요?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧩 구현/변경 사항
사용자 시나리오(UML)
참고
💬 리뷰 받고 싶은 부분 (옵션)